London | SDC-Nov-25 | Emiliano Uruena | Sprint 4 | Implement shell Tools Python#283
Open
Emilianouz wants to merge 4 commits intoCodeYourFuture:mainfrom
Open
London | SDC-Nov-25 | Emiliano Uruena | Sprint 4 | Implement shell Tools Python#283Emilianouz wants to merge 4 commits intoCodeYourFuture:mainfrom
Emilianouz wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
Emilianouz
added
📅 Sprint 4
LonMcGregor
added
the
Review in progress
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
LonMcGregor
reviewed
Jan 7, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on these tasks. They might be improved further if you consider my question about argument parsing
LonMcGregor
added
Reviewed
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Emilianouz
force-pushed
the
Sprint4-ShellPy
branch
from
f8687cc to
d341d5c
Compare
Add argparse for basic flag parsing and automatic help support
Emilianouz
added
Needs Review
|
Good work adding the argparse library - could you do this for the other tasks as well? This really helps to improve the overall implementation. |
LonMcGregor
added
Reviewed
Refactor ls command to use argparse for argument parsing.
Refactor command-line argument parsing to use argparse for better handling of options and file inputs.
Emilianouz
added
Needs Review
|
Good work, task complete. |
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Implementing shell tools: cat, ls, and wc in python.